Back to stories

Comments

60 total · 60 loaded

Ranked by HN
skybrian6hon HN
This autocomplete suggests domains that don't exist. You can just type garbage and it will suggest something, but then if you go there, there are no records.

It seems like one purpose of an autocomplete box is help you avoid typos, so that makes it less useful.

Author here.

Yes, it will autocomplete the most popular domains first, then known registered domains, and then fall back to appending popular TLDs.

The reason is that it's impossible to enumerate all domains. gTLDs (like .com, .info) mostly publish their zone files, but ccTLDs (like .cn, .de) usually don't.

But maybe you're right. After reading these comments, it's clearly confusing to people.

The autocomplete seemed to suggest real domains to me. If you typed in garbage it suggested the garbage plus a bunch of common TLDs - that seems like a reasonable choice to me. In any case, if your issue is the list of domains to suggest, its trivial to change that to a different list.
Yes, OP seems to have completely lost touch with what is actually useful vs optimizing metrics for the sake of it.
But there is a cool blog post about it though.
That's also the old behaviour of browsers and the current one of text browsers. I fail to see how this is wrong.

    $ lynx doesnotexist2

    Looking up doesnotexist2 first
    Looking up www.doesnotexist2.com, guessing...
    Looking up www.doesnotexist2.edu, guessing...
    Looking up www.doesnotexist2.net, guessing...
    Looking up www.doesnotexist2.org, guessing...
    Can't Access `file://localhost/home/user/doesnotexist2'
This behavior seems to happen only when there is no more words in the list that can complete the current string. Otherwise, it shows only existing domains.

I guess this behavior helps to autocomplete the domain extension for less-known domains that are not in the search list.

chrismorgan6hon HN
Using keyup makes no sense and is inconsistent with user expectations. For triggering actions (which includes normal typing), you only ever use keydown. (Well, there’s one exception for reasons unclear to me: activating a button by pressing Space. That triggers on keyup like how clicks are on release, while Enter triggers on keydown.) Keyup is limited to things where you’re constantly reacting to the state of a key, as is common in games.

This affects the functionality, too. It is in fact introducing latency by using keyup instead of keydown. Feels bad.

danbruc4hon HN
For triggering actions (which includes normal typing), you only ever use keydown.

I think you have this wrong, actions generally occur on button release, until that you can move the mouse cursor to a different target, tab to another control, use [ESC] to cancel, and so on. Typing, moving a slider with the cursor keys, and similar things that make use of key repetition while holding down the key are the exception to this.

okamiueru3hon HN
Can you give some specific examples? In my experience (which I also verified to make sure), all of the things you mention act on keydown. The exceptions are on multi-key combinations, which follow a special key that is held down while modifiers are entered, where the action is completed by releasing this special key (ALT + TAB [...TAB | SHIFT]) being a common example.

TAB is otherwise immediate, as is ESC, and the examples of typing, as well. So I'm left wondering, how do they have it wrong?

wongarsu3hon HN
> all of the things you mention act on keydown

Because they listed the exceptions to the "act on keyup" rule

If only one case follows your rule, and everything else ever implemented from the start of personal computers is an exception, your rule is awry.
The GP means that, if you hold space down on a button, you can then tab to another button without activating the first one.
chrismorgan3hon HN
I am speaking specifically of keyboards. For mice, it’s release. (When I made a similar comment two months ago on Lobsters when this article came up there, I mentioned this, but decided to leave it out this time, thinking the context was clear enough. I think I was wrong.)
If it matters, it seemed pretty clear to me. You're also explicit about it, so I'm not sure how one would think you were referring to mouse input. Unless people type by clicking on a virtual keyboard? Benefit of the doubt can only stretch so far.
hnlmorg4hon HN
Key down is used for events that can be duplicated by holding the key. Eg in a text editor, when you want multiples of the same letters, you’d press and hold the key.

Key up is used for when it’s important to only have one occurrence of that event.

Technically you could write code that made key down only react once. But the logical separation makes some sense.

chrismorgan3hon HN
Give me an example. Any example beyond this Space one we’re discussing; because I don’t know of any.
youngtaff2hon HN
I can see both viewpoints here and don’t have a strong personal view

But for reference browsers fire the keypress event on keyup

The keypress event is an ancient mistake that I think never had any legitimate use case, and has been deprecated for quite some time now.
zxexz6hon HN
As a user, I’ve not thought too much about this before now. I agree with you mostly, but the keyup on space behaviour actually feels so innate I’d hate any change to it. Keydown on space is “jump”; nothing else.
chrismorgan6hon HN
I’d just like to hear an explanation of why it is. Because if you handled “is key currently pressed” events with polling rather than events (which is how people almost always consume them logically), it would be the only thing in the entire world that I can think of that would/should use keyup.

Edit: I think people are misunderstanding me. I’m asking for an explanation of why, when you have a button focused, pressing Space activates on key up, rather than key down like literally everything else on the keyboard, including Enter on a focused button. (Mouse activates on release.)

Rygian5hon HN
Because in those contexts, the Space key is being used as a physical mirror of the on-screen button, and on-screen buttons are UX'd to perform action when released.

These two interactions should behave identically:

- Hover over a button, press mouse button 1, release button 1.

- Tab over to a button, press spacebar, release spacebar.

Why on-screen buttons are UX'd to behave this way is a logical follow-up question. I'd wager that it gives a means to bail out of the clicking (e.g. by moving the mouse out of the on-screen button before releasing mousebutton 1, or by pressing Esc while having spacebar still depressed).

Yes, the bailing-out explanation is right. With a mouse it's intentional that you should be able to push the pointer off the button with the mouse button still pressed to cancel.
chrismorgan4hon HN
(Esc while Space is held doesn’t cancel, but Tab does.)

You’re only answering half of the inconsistency: because Enter activates buttons like any other key, on keydown.

Just diving in without full context, but, enter is often a completion action. Historically often a full carriage return. It often means "submit data".

So this could be the oddity

podocarp5hon HN
It just matches real life. What about lmb to shoot? You don't fire a gun on trigger release, you fire it on trigger down. Walking? Would be weird moving only on keyup.
This raises the question of why real life buttons and virtual buttons behave differently. My unsubstantiated guess is that clicks act on release to give the opportunity to slide off the button to abort, and/or because the button would disappear while pressing if it ex. submits a form.
dangond5hon HN
Jump is keydown because many games let you adjust your jump height based on how long you hold down space after the jump starts.
Games use keydown because it is more responsive and control responsiveness is vital to dynamic gameplay feeling good. There are some exceptions - if action can be charged, then it is on keydown. And then on gamepad sometimes actions are on release when developer has too many actions and not enough buttons, so it can be keyup vs hold.
I may be wrong on this, but I think that pressing esc while space is held down cancels the button press, like moving the mouse off the key while holding down the click does. I'd need to test this, though.
That’s where the input event is really useful as it allows for more input options than just keyboard and then you don’t have to deal with figuring out if it’s down or up.
On my own computer I can open a context menu and select an action with a single click. Whenever I need to use MS Windows, I always need two and I find that infuriating every time.
Unfortunately this approach doesn't feel that great down here in Australia, definitely a function of latency.

I think you could get a lot closer by framing this as an optimization problem, where you use the full alphabet dictionary, but add a residual prediction which aims to cover as much of the remaining domain name tree as possible weighted by popularity. This tree could then be pre-baked and stored with the same system. This would probably get you p99 0ms even in Australia.

Interesting, I didn't think of that yet.

I think most people search for domains they own, which doesn't correlate with Tranco popularity ranking. Treating 'popularity' not as a function of visitors, but as a function of number of known domain names with that prefix could work, though.

oersted6hon HN
Why not just trigger the fetch on keyDown and show it as soon as the response arrives, as usual?

The time it takes to press a key is a reasonable target to aim at for API latency I suppose, but it is still an arbitrary target. Waiting to display until keyUp just adds more latency if your API is faster. Having it synced with keyUp doesn't make it feel more immediate to me.

kevmo3146hon HN
If you’d like to reduce the network latency further you can store each trie node as a file, naming it conveniently the prefix path to that node. Then dump the few hundred million files onto R2.

Now the traversal can be done completely via CDN lookups!

pul2hon HN
Cloudflare R2 doesn't distribute files globally. They only cache requested files in PoPs. So then it would function the same as an API behind the Cloudflare CDN.
kevmo3142hon HN
It would skip the Cloudflare to server network hop that the author mentions being rather expensive for cache misses.
It would replace the Cloudflare to server network hop with a cloudflare PoP to R2 hop. That covers approximately the same geographical distance and results in similar latency.

(I'm the author btw)

piterrro3hon HN
I just typed a random sequence of the characters, long enough to be certain such domain doesnt exist. No only, the browser send an autocomplete request for every keystroke but for each request it returned a set of proposed domain names (which I'm 100% certain doesnt exist). At this point, how do I understand which results are legit and which are fake? Also, it would be nice to highlight the typed part in the result set so I can visually see what matches exactly.
You're not the first to mention this, so clearly users expect something different from what I've designed it for. I think I'll drop the TLD postfix suggestions.
For the nonexisting domains, it seems like it only autocomplete with the possible domain extensions, (e.g .com, .org, ....) as the search list is non-exhaustive. But it could indeed be improved by not sending autocomplete requests anymore.
Clever but that’s not how we measure latency.
dbalatero7hon HN
When it comes to UX, perceived latency is king.
wky7hon HN
The perceived latency starts from keydown, not keyup. Redefining latency to start at keyup reduces measured latency, not perceived latency, and delaying the visual display to keyup makes perceived latency strictly worse, not better. Even sticking with the keyup definition, just displaying the result as soon as it is available gives the possibility of negative (defined) latency.
I think you don't fully understand. They aren't just doing a search based on the key being pressed down. They already did a search based on the previous characters that returned results for all possible next characters. So by the time you type a second character it just checks results locally from the search that had likely already been returned from when you had typed the previous character.
wky6hon HN
They do that, yet proceed to kneecap the perceived latency by delaying the render.

> And on keyUp (the user releases the key), we render the suggestions.

There are a large number of edge cases where rendering it on key down would not be desirable (user types Ctrl+v, how accented characters are enetered, how some Asian languages get handled, backspace/delete, user holds a key down, etc). This is getting into the point of optimization where it simply does not matter and can actually harm things
wky5hon HN
Holding a key would indeed require both on key down and up. I'd still argue that handling rerender on key down (or to fully match whatever OS/browser semantics, oninput) makes more sense than key up. Pressing Ctrl+V for example produces feedback as soon as "V" is pressed, not when Ctrl and/or V is released.

Interestingly Ctrl+V on OP's website does update immediately when Ctrl+V is pressed.

Why would you argue that makes more sense? That is not how any autocomplete works that I know of, it's not like this is a new pattern.
What you said might be true and yet what OPs AI agent did wasn't measure latency of the service nor calculated a p99 for it.
KeyDown events don’t work great for mobile, though.
Autocomplete aside, this is a pretty nifty tool.
pixelpoet7hon HN
Pretty sure we mean < 1ms rather than actually instantaneous.
On a technical level yes but once you factor in monitor refresh rates then you can get to levels of optimization where it simply doesn't matter because you are constrained by waiting for the refresh rate anyways.
Its like tic tacs saying they are 0 calories because they got the per serving size down low enough to round to 0.
its pretty clever but what happns when someone pastes a domain or uses IME or voice input? the api being that fast is still impressive.
Or uses swipe gestures on mobile keyboard!